Skip to content

Conversation

@sriram-mv
Copy link
Contributor

Better UX overall.

logs

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sriram-mv sriram-mv requested a review from a team as a code owner June 22, 2023 00:13
@sriram-mv sriram-mv requested review from mndeveci and moelasmar June 22, 2023 00:13
@github-actions github-actions bot added area/logs sam logs command pr/internal labels Jun 22, 2023

LOG = logging.getLogger(__name__)

SHORT_HELP = "Fetch logs for your AWS SAM Application."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change this text to mention that we support CFN stacks as well.

@sriram-mv sriram-mv added this pull request to the merge queue Jul 3, 2023
Merged via the queue into aws:develop with commit 9877db2 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/logs sam logs command pr/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants